feature/logo-centering #4

Closed
CodyWan-Kenobi wants to merge 0 commits from refs/pull/4/head into main
CodyWan-Kenobi commented 2026-01-06 16:26:16 +00:00 (Migrated from codeberg.org)

Configuration Options Added

Users can now add this to their config.toml:

[display]
logo_offset = 0  # Fine-tune logo horizontal position
                 # Negative values shift left (e.g., -3)
                 # Positive values shift right (e.g., 5)
                 # Default: 0 (uses automatic centering)

The logo will automatically center properly without any configuration changes. The logo_offset option is provided because images can drift slightly as they get larger, though sane image sizes (around 100-300px) look good with the default centering. Users can fine-tune positioning if needed for their specific image size and terminal setup.

Testing

  • Compiles with zero warnings
  • Tested with various image sizes and aspect ratios
  • Logo now properly centers above greeting and system info
  • Offset adjustment confirmed working (-5 to +5 range tested)

Note: Cargo.lock changes not included as they're unrelated dependency updates.

### Configuration Options Added Users can now add this to their `config.toml`: ```toml [display] logo_offset = 0 # Fine-tune logo horizontal position # Negative values shift left (e.g., -3) # Positive values shift right (e.g., 5) # Default: 0 (uses automatic centering) ``` The logo will automatically center properly without any configuration changes. The `logo_offset` option is provided because images can drift slightly as they get larger, though sane image sizes (around 100-300px) look good with the default centering. Users can fine-tune positioning if needed for their specific image size and terminal setup. ### Testing - Compiles with zero warnings - Tested with various image sizes and aspect ratios - Logo now properly centers above greeting and system info - Offset adjustment confirmed working (-5 to +5 range tested) *Note: Cargo.lock changes not included as they're unrelated dependency updates.*
thelinuxcast commented 2026-01-07 06:44:30 +00:00 (Migrated from codeberg.org)

How does this affect users who just use the ascii art?

How does this affect users who just use the ascii art?
CodyWan-Kenobi commented 2026-01-07 06:51:58 +00:00 (Migrated from codeberg.org)

the ascii art seems to default to the right, is this expected behaviour? I might have missed this as i was focusing on images, as far as i know this only affects image placement when on top

the ascii art seems to default to the right, is this expected behaviour? I might have missed this as i was focusing on images, as far as i know this only affects image placement when on top
thelinuxcast commented 2026-01-07 06:53:25 +00:00 (Migrated from codeberg.org)

I'll be honest, I haven't tested the ascii art much myself. lol. I'll look at both of these PRs tomorrow, and I'll see what the ascii thing does in top one|two mode.

I'll be honest, I haven't tested the ascii art much myself. lol. I'll look at both of these PRs tomorrow, and I'll see what the ascii thing does in top one|two mode.
CodyWan-Kenobi commented 2026-01-07 06:58:50 +00:00 (Migrated from codeberg.org)

Ok let me know if this has caused a regression in this regard and I can probably make the appropriate fixes

Ok let me know if this has caused a regression in this regard and I can probably make the appropriate fixes
thelinuxcast commented 2026-01-07 21:00:36 +00:00 (Migrated from codeberg.org)

The automatically centered bit doesn't work for me at all. The picture here is with an offset of 0. Which, if I understand correctly, should mean that it is centered automatically?

The automatically centered bit doesn't work for me at all. The picture here is with an offset of 0. Which, if I understand correctly, should mean that it is centered automatically?
thelinuxcast commented 2026-01-07 21:02:46 +00:00 (Migrated from codeberg.org)

It also severely messes with one row/top.

It also severely messes with one row/top.
CodyWan-Kenobi commented 2026-01-08 05:40:01 +00:00 (Migrated from codeberg.org)

Oh that's interesting i tested it on mine with about 6 different logo pictures and my results where much different, I'll have to look into this further

Oh that's interesting i tested it on mine with about 6 different logo pictures and my results where much different, I'll have to look into this further
CodyWan-Kenobi commented 2026-01-09 04:33:22 +00:00 (Migrated from codeberg.org)

I'm going to go back to the drawing board for this

I'm going to go back to the drawing board for this

Pull request closed

Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
thelinuxcast/mattfetch!4
No description provided.