feature/logo-centering #4
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "refs/pull/4/head"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Configuration Options Added
Users can now add this to their
config.toml:The logo will automatically center properly without any configuration changes. The
logo_offsetoption is provided because images can drift slightly as they get larger, though sane image sizes (around 100-300px) look good with the default centering. Users can fine-tune positioning if needed for their specific image size and terminal setup.Testing
Note: Cargo.lock changes not included as they're unrelated dependency updates.
How does this affect users who just use the ascii art?
the ascii art seems to default to the right, is this expected behaviour? I might have missed this as i was focusing on images, as far as i know this only affects image placement when on top
I'll be honest, I haven't tested the ascii art much myself. lol. I'll look at both of these PRs tomorrow, and I'll see what the ascii thing does in top one|two mode.
Ok let me know if this has caused a regression in this regard and I can probably make the appropriate fixes
The automatically centered bit doesn't work for me at all. The picture here is with an offset of 0. Which, if I understand correctly, should mean that it is centered automatically?
It also severely messes with one row/top.
Oh that's interesting i tested it on mine with about 6 different logo pictures and my results where much different, I'll have to look into this further
I'm going to go back to the drawing board for this
Pull request closed